Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove elm production warning #278

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

jouderianjr
Copy link
Contributor

Hello @dillonkearns, I'm not very proud of this fix but it is a quick workaround in order to remove the annoying warning message :)

@dillonkearns
Copy link
Owner

If we wanted to, we could preserve the original console.warn function and then restore it after running the Elm part of the process like I do here:

https://github.com/dillonkearns/elm-pages/blob/master/generator/src/compile-elm.js#L12-L29

But that might be unnecessary. How about we add a simple comment there that points to this issue and the relevant context in case our future selves get confused?

@dillonkearns
Copy link
Owner

Thanks for opening the PR! 😄

@jouderianjr
Copy link
Contributor Author

If we wanted to, we could preserve the original console.warn function and then restore it after running the Elm part of the process like I do here:

https://github.com/dillonkearns/elm-pages/blob/master/generator/src/compile-elm.js#L12-L29

But that might be unnecessary. How about we add a simple comment there that points to this issue and the relevant context in case our future selves get confused?

yeah, even if it is not exactly necessary, restore the console.warn will avoid unexpected behavior.

I also added a comment, let me know about the text, I can change as you prefer 💃

@dillonkearns
Copy link
Owner

👍 Thanks for making a PR for this @jouderianjr!

@dillonkearns dillonkearns merged commit 1f59935 into dillonkearns:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants