Add --compiler option #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran the TypeScript formatter on elm-graphql.ts as well.
|
Hey @dillonkearns! I'm sure you're very busy so I understand if you don't have time for this, but I just wanted to call out that this feature would still be very useful for myself and my team, should you have a little bit of time with which to review this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new CLI flag,
--compiler, that allows you to pass the path to the elm compiler that you'd like theelm-graphlexecutable to use when verifying custom scalar codecs (should it be used for more than just that?).Full disclosure: I've never written any TypeScript and hardly ever write JavaScript.
Closes #276
I tested this manually by altering the command used in
npm run gen:starwarsand then running that. Is there a better (more automated) way?This currently only does anything if the
--scalar-codecsoption is also provided. Is that ok? Should we let the user know?