Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommTrack module: setvalue -> bind #931

Merged
merged 3 commits into from
Jan 9, 2018
Merged

Conversation

millerdev
Copy link
Contributor

https://manage.dimagi.com/default.asp?267194

Ignore the first commit, which just adds package-lock.json

Best to review the other two commits individually 🐠

@emord @orangejenny

@millerdev
Copy link
Contributor Author

millerdev commented Jan 9, 2018

@dimagi/product I'm not sure if this should be documented or not. It's a pretty low-level detail about how ledger question types are written by the form builder. Maybe this should be categorized as invisible?

Existing forms will need to be loaded in the form builder and saved (no other changes necessary) to have <setvalue> nodes converted to <bind> nodes.

@sheelio
Copy link
Contributor

sheelio commented Jan 9, 2018

@millerdev

I'd mark as product/feature-flag since I think Supply is behind a feature flag. The change is that instead of using a setvalue for certain ledger entries we'd use a bind?

@millerdev
Copy link
Contributor Author

I'd mark as product/feature-flag since I think Supply is behind a feature flag.

Done. Thanks!

The change is that instead of using a setvalue for certain ledger entries we'd use a bind?

Correct.

@millerdev millerdev merged commit 6602441 into master Jan 9, 2018
@millerdev millerdev deleted the dm/commtrack-setvalue-to-bind branch January 9, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants