[2.50.3] Lets Encrypt Root CA Change #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great to see this PR. |
yschimke
reviewed
Nov 20, 2020
| Certificate isgCertificate = cf.generateCertificate(new ByteArrayInputStream(isgCert.getBytes("UTF-8"))); | ||
|
|
||
| HandshakeCertificates certificates = new HandshakeCertificates.Builder() | ||
| .addTrustedCertificate((X509Certificate)isgCertificate) |
There was a problem hiding this comment.
Do you need to support other platform certificates as well? Or just an LE root?
Can you confirm this already works for existing LE certificates?
There was a problem hiding this comment.
Do you need to support other platform certificates as well?
Uh yes, It's failing for other non LE certs. so seems like we need to add addPlatformTrustedCertificates() to allow for other certificates. Appreciate the catch.
Can you confirm this already works for existing LE certificates?
Yeah this somehow works without adding the call to addPlatformTrustedCertificates(). Not sure how though!
|
@damagatchi retest this please |
ShivamPokhriyal
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://letsencrypt.org/2020/11/06/own-two-feet.html
Solution taken from:
https://stackoverflow.com/questions/64844311/certpathvalidatorexception-connecting-to-a-lets-encrypt-host-on-android-m-or-ea
OkHttp Issue: square/okhttp#6403