Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hint text visibility #2439

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Fix hint text visibility #2439

merged 1 commit into from
Feb 23, 2021

Conversation

ShivamPokhriyal
Copy link
Contributor

Fixes an issue caused by #2417 where hint text gets hidden always.

@ShivamPokhriyal ShivamPokhriyal added product/all-users critical-bug-fix For bug fixes that are important enough to be included in the next LTS point release labels Feb 22, 2021
@ShivamPokhriyal ShivamPokhriyal added this to the 2.51.1 milestone Feb 22, 2021
@shubham1g5
Copy link
Contributor

can we incorporate checking for hint text as part of current integration tests ?

@ShivamPokhriyal
Copy link
Contributor Author

can we incorporate checking for hint text as part of current integration tests ?

Definitely, I'll create a followup PR later for this.

@ShivamPokhriyal ShivamPokhriyal merged commit 6b4ebb9 into commcare_2.51 Feb 23, 2021
@ShivamPokhriyal ShivamPokhriyal deleted the hint-visiblity branch February 23, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham1g5 shubham1g5 shubham1g5 approved these changes

Assignees
No one assigned
Labels
critical-bug-fix For bug fixes that are important enough to be included in the next LTS point release product/all-users
Projects
None yet
Milestone
2.51.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ShivamPokhriyal @shubham1g5