Merge pull request #22831 from dimagi/rn_remove_feature_flag

Remove Feature Flag from Ls dashboard
dimagi · Dec 26, 2018 · 3fe7dee · 3fe7dee
2 parents 0dd1f8f + 74ed172
commit 3fe7dee
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/custom/icds_reports/static/icds_reports/js/spec/navigation.directive.spec.js b/custom/icds_reports/static/icds_reports/js/spec/navigation.directive.spec.js
@@ -11,9 +11,7 @@ describe('Navigation Directive', function () {
     var $rootScope, $compile, $httpBackend, controller;
 
     var myScope;
-    beforeEach(module('icdsApp', function ($provide) {
-        $provide.constant("haveAccessToFeatures", false);
-    }));
+    beforeEach(module('icdsApp'));
 
     beforeEach(inject(function (_$rootScope_, _$compile_, _$httpBackend_) {
         $compile = _$compile_;

diff --git a/custom/icds_reports/static/js/directives/navigation/navigation.directive.js b/custom/icds_reports/static/js/directives/navigation/navigation.directive.js
@@ -2,11 +2,10 @@
 
 var url = hqImport('hqwebapp/js/initial_page_data').reverse;
 
-function NavigationController($window, $scope, $route, $routeParams, $location, haveAccessToFeatures) {
+function NavigationController($window, $scope, $route, $routeParams, $location) {
     $scope.$route = $route;
     $scope.$location = $location;
     $scope.$routeParams = $routeParams;
-    $scope.haveAccessToFeatures = haveAccessToFeatures;
 
     var checkColapse = function(reports) {
         var path = _.filter(reports, function(report) { return $location.path().indexOf(report) !== -1; });
@@ -38,7 +37,7 @@ function NavigationController($window, $scope, $route, $routeParams, $location,
     };
 }
 
-NavigationController.$inject = ['$window', '$scope', '$route', '$routeParams', '$location', 'haveAccessToFeatures'];
+NavigationController.$inject = ['$window', '$scope', '$route', '$routeParams', '$location'];
 
 window.angular.module('icdsApp').directive('navigation', function() {
     return {

diff --git a/custom/icds_reports/templates/icds_reports/icds_app/navigation.directive.html b/custom/icds_reports/templates/icds_reports/icds_app/navigation.directive.html
@@ -137,7 +137,7 @@
                     <div class="col-sm-9">{% trans "AWC Report" %}</div>
                 </a>
             </li>
-            <li ng-if="haveAccessToFeatures" ng-class="{'active': $location.path().indexOf('/lady_supervisor') !== -1}">
+            <li ng-class="{'active': $location.path().indexOf('/lady_supervisor') !== -1}">
                 <a class="row pointer" href="{$ goToStep('lady_supervisor', $location.search()) $}" style="width: 100%" ng-click="healthCollapsed = true; icdsCasReach = true; demographics = true; infrastructure = true;">
                     <div class="col-sm-1"><i class="fa fa-tasks" aria-hidden="true"></i></div>
                     <div class="col-sm-9">{% trans "LS Dashboard" %}</div>