Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ucr report data tests #11709

Merged
merged 2 commits into from May 23, 2016
Merged

Ucr report data tests #11709

merged 2 commits into from May 23, 2016

Conversation

czue
Copy link
Member

@czue czue commented May 23, 2016

@nickpell @NoahCarnahan - I wanted to add a new column type to reports and wanted to start with a test and realized that it didn't look like we had any good end-to-end tests for the report data source class (apart from the expanded column ones that noah wrote). Does that sound right to you or did I just miss them?

@NoahCarnahan
Copy link
Contributor

I believe you are correct that we don't have much in the way of end-to-end ucr reports. These look good!
👍 on ✅

@nickpell
Copy link
Contributor

looks like TestReportAggregation provides some limited end-to-end testing of building a data source and querying a report (but not limit or skip)

@czue
Copy link
Member Author

czue commented May 23, 2016

oh cool - missed that since it tests the view and not the data source. might try and reconcile them at some point. ✅

@nickpell nickpell merged commit 1b0f220 into master May 23, 2016
@nickpell nickpell deleted the ucr-report-data-tests branch May 23, 2016 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants