reference form attachments in case attachments instead of copying #13200
Conversation
| @run_with_all_backends | ||
| def test_case_attachment(self): | ||
| single_attach = 'fruity_file' | ||
| xform, case = self._doCreateCaseWithMultimedia(attachments=[single_attach]) |
There was a problem hiding this comment.
This sends attachments to submit_form_locally, which I would expect to work. I thought case attachments were working, but still stored in couch. Is that not true?
There was a problem hiding this comment.
Case attachments come from form attachments hence the call to
submit_form_locally
The SQL backend uses the blobdb for all attachments (form and case).
Currently we duplicate form attachments for cases so one thing we could
consider is just referencing the same blob in both the form and case.
I also see that boto S3 has a copy API method which we could also use
rather than doing a read and then write.
There was a problem hiding this comment.
I'm trying out the copy API right now. Will have a PR soon, hopefully.
snopoke
force-pushed
the
sk/copy_blob
branch
from
9a9de02
to
ec2781f
Compare
snopoke
changed the title
snopoke
force-pushed
the
sk/copy_blob
branch
from
ec2781f
to
7c9b7ff
Compare
snopoke
force-pushed
the
sk/copy_blob
branch
from
7c9b7ff
to
7d039ed
Compare
snopoke
changed the title
| with trap_extra_setup(AttributeError, msg="S3_BLOB_DB_SETTINGS not configured"): | ||
| config = settings.S3_BLOB_DB_SETTINGS | ||
| self.s3db = TemporaryS3BlobDB(config) | ||
| assert get_blob_db() is self.s3db, (get_blob_db(), self.s3db) |
There was a problem hiding this comment.
nit: the above two lines don't need to (and probably shouldn't) be in the with trap_extra_setup block.
|
👍 on ✅ |
|
✅ |
@millerdev
buddy @calellowitz