Remove broken and barely couch view cases_get_lite/get_lite #23509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emord
approved these changes
Mar 4, 2019
| # starting on Mar 28, 2018 8:00:08 AM EDT. | ||
| # When getting rid of the long-broken cases_get_lite couch design doc, | ||
| # Danny decided to remove this failing task entirely, | ||
| # which should have the same effect as running once a day and failing once a day. |
There was a problem hiding this comment.
I think this comment should just be removed totally. its pretty close to commenting out code, and I don't see how this "tombstone" is going to help someone in the future figure out a bug that's already been failing for a year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view is broken on production, i.e. the view is completely empty, despite the intention being that it emit one thing per couch case. On india, it does seem to work. I have evidence of a pact view failing on Mar. 28, 2018 due to an error this would have caused, so that's my best guess as the date at which
cases_get_lite/get_litestarted emitting nothing on prod.Almost all usages could be traced back to tests; the one exception being the usage in pact code mentioned above, which has been broken for about a year.
Probably easiest to review commit by commit.