upgrade to celery 4.1.1 #23650
Merged
upgrade to celery 4.1.1 #23650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpell
requested review from
emord,
esoergel,
kaapstorm and
millerdev
as code owners
dannyroberts
approved these changes
Mar 14, 2019
nickpell
commented
Mar 15, 2019
| @@ -509,11 +504,11 @@ | |||
| GET_URL_BASE = 'dimagi.utils.web.get_url_base' | |||
|
|
|||
| # celery | |||
| BROKER_URL = 'redis://localhost:6379/0' | |||
| CELERY_BROKER_URL = 'redis://localhost:6379/0' | |||
There was a problem hiding this comment.
@dimagi/team-commcare-hq Heads up that we're now running celery 4. To run celery locally will require updating localsettings with the variable name changes here, and with the changes in localsettings.py
BROKER_URL -> CELERY_BROKER_URL
CELERY_ALWAYS_EAGER -> CELERY_TASK_ALWAYS_EAGER
CELERY_ANNOTATIONS -> CELERY_TASK_ANNOTATIONS
CELERYD_TASK_SOFT_TIME_LIMIT -> CELERY_TASK_SOFT_TIME_LIMIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not upgrading to the latest version of celery we avoid this bug:
celery/celery#4980
The bug is on the 4.3.x roadmap so we should be able to upgrade once that is released.