Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user provisioning PR feedback #26946

Merged
merged 2 commits into from Mar 24, 2020
Merged

user provisioning PR feedback #26946

merged 2 commits into from Mar 24, 2020

Conversation

czue
Copy link
Member

@czue czue commented Mar 24, 2020

Feedback on #26920 and #26935

SUMMARY
FEATURE FLAG
PRODUCT DESCRIPTION

@czue czue added the product/custom Change will only impact users on a single project label Mar 24, 2020
@czue czue requested a review from orangejenny March 24, 2020 09:31
@czue czue requested a review from esoergel as a code owner March 24, 2020 09:31
orangejenny
orangejenny approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@orangejenny orangejenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick folllowup.

@czue czue merged commit 152dc03 into master Mar 24, 2020
@czue czue deleted the cz/user-provisioning-pr-feedback branch March 24, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangejenny orangejenny orangejenny approved these changes

@esoergel esoergel Awaiting requested review from esoergel esoergel is a code owner

Assignees
No one assigned
Labels
product/custom Change will only impact users on a single project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@czue @orangejenny