Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pagination of location and location type APIs #27831

Merged
merged 1 commit into from Jun 17, 2020
Merged

Conversation

czue
Copy link
Member

@czue czue commented Jun 17, 2020

Currently the pagination parameters (e.g. next) of the location apis are always empty. This is because we are improperly setting the resource URI on the list view so tastypie can't render them

The relevant side effect of this is that it's impossible to paginate through locations with the DET which relies on the next param to handle pagination.

SUMMARY
FEATURE FLAG
RISK ASSESSMENT / QA PLAN
PRODUCT DESCRIPTION

not necessary to announce

@czue czue added the product/all-users-all-environments Change impacts all users on all environments label Jun 17, 2020
@czue czue requested a review from esoergel as a code owner June 17, 2020 09:14
@czue
Copy link
Member Author

czue commented Jun 17, 2020

if this gets approved could you please also merge it? it's blocking some testing and would like to sneak it into the next deploy if possible (though no need for a special deploy for it)

Copy link
Contributor

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge when tests pass

@calellowitz calellowitz merged commit 591ede5 into master Jun 17, 2020
@calellowitz calellowitz deleted the cz/location-api branch June 17, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants