refactor custom app routing #28099
Merged
refactor custom app routing #28099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jul 13, 2020
|
|
||
| # map to reporting DB alias | ||
| with override_settings(CUSTOM_DB_ROUTING={'custom_app': 'icds-ucr-citus'}), \ | ||
| override_engine('icds-ucr-citus', '', db_alias='icds-ucr'): |
There was a problem hiding this comment.
E127 continuation line over-indented for visual indent
| # map to reporting DB alias | ||
| with override_settings(CUSTOM_DB_ROUTING={'custom_app': 'icds-ucr-citus'}), \ | ||
| override_engine('icds-ucr-citus', '', db_alias='icds-ucr'): | ||
| self.assertIs(False, allow_migrate(DEFAULT_DB_ALIAS, 'custom_app')) |
|
|
||
| AAA_DB_ENGINE_ID = 'aaa-data' | ||
|
|
||
| def get_aaa_db_alias(): |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
snopoke
commented
Jul 13, 2020
| elif app_label == AAA_APP: | ||
| engine_id = AAA_DB_ENGINE_ID | ||
| if not write: | ||
| return connection_manager.get_load_balanced_read_db_alias(AAA_DB_ENGINE_ID) |
There was a problem hiding this comment.
this load balancing is removed but it's not active on any environment anyway. I think the original code was just copied from the ICDS code at the time.
|
This is now love on |
sravfeyn
reviewed
Jul 21, 2020
| @@ -1396,6 +1398,13 @@ | |||
| if 'corehq.sql_db.routers.MultiDBRouter' not in DATABASE_ROUTERS: | |||
| DATABASE_ROUTERS.append('corehq.sql_db.routers.MultiDBRouter') | |||
|
|
|||
| # Mapping of app_label to DB name or reporting DB alias (see REPORTING_DATABASES) | |||
| CUSTOM_DB_ROUTING = { | |||
There was a problem hiding this comment.
Isn't the plan to do this via commcare-cloud setting override?
There was a problem hiding this comment.
sravfeyn
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Refactor app custom app routing to be defined in settings
related localsettings change: dimagi/commcare-cloud#3972