use npm version of ui-select #28175
Merged
use npm version of ui-select #28175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biyeun
added
dependencies
millerdev
approved these changes
Jul 21, 2020
| @@ -2,6 +2,8 @@ | |||
| set -e | |||
|
|
|||
| make requirements | |||
| # we want to hard ignore any yarn.lock changes | |||
| git checkout -- yarn.lock | |||
There was a problem hiding this comment.
Is this a stop-gap measure to get tests passing while we figure out why yarn.lock is changing? Seems less than ideal to have yarn installing unlocked versions of libraries for tests.
If this is the permanent fix then I think I want to withdraw my approval for this PR.
There was a problem hiding this comment.
@millerdev this is a stopgap. i'm still pretty perplexed how this is happening to begin with with the frozen-lockfile flag explicitly used...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
some builds were timing out trying to pull
ui-selectfrom the github repo. thenpmversion looks close enough to the one on github that it should be ok. and all js tests are passing.