Commit field back population migration #28287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@esoergel I can't request a review, so I'll just tag you here. |
AliRizvi1
added
product/admin
esoergel
reviewed
Aug 4, 2020
| def back_populate(apps, schema_editor): | ||
| HqDeploy = apps.get_model('hqadmin', 'hqdeploy') | ||
| for deploy in HqDeploy.objects.all(): | ||
| if not deploy.commit: |
There was a problem hiding this comment.
Suggested change
| if not deploy.commit: | |
| if deploy.diff_url and not deploy.commit: |
diff_url is sometimes None
esoergel
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27839
A feature of the above CEP, related to #28234 which added the commit field.
SUMMARY
Add a migration to hqadmin that back populates the commit field detailed in the PR above based on the
diff_url.PRODUCT DESCRIPTION
User's commit field in the HqDeploy model will now be back populated with commits based on their
diff_url, and those changes will be reflected in the standalone Deploy History Report.