treat null and blank the same in pre filters #28315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czue
added
Open for review: do not merge
millerdev
approved these changes
Aug 6, 2020
Co-authored-by: Daniel Miller <dmiller@dimagi.com>
|
Ok, I'm pretty convinced this is the right behavior. Will give the weekend for any other @dimagi/product people to weigh in and then plan to merge this on Tuesday. It's easy enough to revert back if it trips someone up. |
snopoke
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of https://github.com/dimagi/commcare-hq/pull/28313/files#r466225716 for discussion from @dimagi/product or others. Don't merge unless it's cleared.
SUMMARY
This treats prefilters against null the same as prefilters against empty strings.
FEATURE FLAG
RISK ASSESSMENT / QA PLAN
Main risk is that someone is actually relying on the fact that these are different.
PRODUCT DESCRIPTION
Some reports that are filtering on nulls may show more data. (I don't think this is worth announcing but worth noting in case it comes up via support)