Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rebuildstaging workflow to use external tool #28473

Merged
merged 3 commits into from
Sep 7, 2020
Merged

update rebuildstaging workflow to use external tool #28473

merged 3 commits into from
Sep 7, 2020

Conversation

snopoke
Copy link
Contributor

@snopoke snopoke commented Sep 3, 2020 •
edited by dannyroberts

Move the rebuild staging tool and associated utils to https://pypi.org/project/git-build-branch/

@snopoke snopoke added the product/invisible Change has no end-user visible impact label Sep 3, 2020
@snopoke snopoke mentioned this pull request Sep 3, 2020
Open
millerdev
millerdev approved these changes Sep 3, 2020
View reviewed changes
requirements/dev-requirements.in Outdated
@@ -12,6 +12,7 @@ wheel==0.29.0
transifex-client==0.12.4
modernize
gnureadline==6.3.8
git-branch-builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: git commands are usually verbs or verb phrases. Ex: git-build-branch. Is it too late to change that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still some way to go in the renaming? The pypi entry and the repo https://github.com/dimagi/git-build-branch are renamed, but looking at the code in the repo it looks like the main directory as well as the executable are still called git-branch-builder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to push my changes. The repo is now updated.

dannyroberts
dannyroberts reviewed Sep 4, 2020
View reviewed changes
Copy link
Member

@dannyroberts dannyroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. What's the new dev workflow? Looks like it's an in place refactor so we still use ./scripts/commit-staging and ./scripts/rebuildstaging?

@snopoke
Copy link
Contributor Author

snopoke commented Sep 7, 2020

@dannyroberts I have tried to keep the dev workflow the same for now.

@snopoke snopoke merged commit 204e2a6 into master Sep 7, 2020
@snopoke snopoke deleted the sk/rebuildstaging branch September 7, 2020 07:50
@sravfeyn
Copy link
Member

sravfeyn commented Sep 7, 2020

I have installed the new requirement and tries ./scripts/rebuildstaging, but it just waits for a long time without any message at

rebuilding staging branch, this might take a while...
Fetching master

@sravfeyn
Copy link
Member

sravfeyn commented Sep 7, 2020

Works okay now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyroberts dannyroberts dannyroberts left review comments

@millerdev millerdev millerdev approved these changes

@esoergel esoergel Awaiting requested review from esoergel

Assignees
No one assigned
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@snopoke @sravfeyn @dannyroberts @millerdev