update flake8

[AmitPhulera]

Product Description

We were couple of versions behind on the flake-8. Since it is a dev dependency and should be safe to upgrade, raising out this PR to do the same.

Safety Assurance

Dev dependency, safe to update. Just affects our linting process.

Automated test coverage

NA

QA Plan

NA

Rollback instructions

• This PR can be reverted after deploy with no further considerations

Labels & Review

• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[millerdev]

I think this breaks our pre-commit hook because it still uses the --diff parameter, which was deprecated in v5 and has been removed in v6.

commcare-hq/git-hooks/pre-commit.sh

Line 53 in 9a5898c

git diff --cached -U0 | flake8 --diff --show-source --config=.flake8

As this issue points out, the --diff option was broken because it did not catch all issues introduced by changed lines.

One option would be to use use flake8-diff, although I'd be a little surprised if that does not have the same flaw as --diff did. Research needed.

Another option is to run flake8 against whole files and recommend that people fix the whole file when they make changes to it. If the changes are extensive, definitely do that in a separate commit, and possibly in a separate PR to reduce the volume of changes in otherwise risky PRs.

[AmitPhulera]

Thanks for the info @millerdev . I now remember this being discussed before, I guess Graham brought it up. I will hold off this PR for now to explore other options.