[B5] Web Apps #34682
Open
[B5] Web Apps #34682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
added
awaiting QA
orangejenny
requested review from
biyeun,
MartinRiese,
AddisonDunn,
stephherbers,
Robert-Costello and
Jtang-1
as code owners
dimagimon
added
dependencies
MartinRiese
reviewed
May 28, 2024
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| +++ | |||
There was a problem hiding this comment.
why are these not unsplit?
There was a problem hiding this comment.
They're still used here:
orangejenny
force-pushed
the
jls/b5-web-apps
branch
from
c8af755
to
ffee7a4
Compare
This is basically the result of running the bootstrap migration tool.
Followup for ee098af
- dateTimePickerTooltips are already handled by by defaultTranslations in the HQ tempus dominus module - Several callbacks/handlers were no longer needed - It's annoying that showing the clear button is handled through initial page data, but updating that is out of scope
This finishes up a43a527
The migration tool doesn't check js files for CSS class names, and some of these aren't greppable anyway.
This completes changes that were started in 845d9ff
…(QA-6725) This reverts commit f946ca3.
… into jls/b5-web-apps
This behavior is not added to the time picker or the date range picker since neither of those are single-click interactions.
This makes tempus dominus more forgiving about users entering single-digit months and years, which would previously be rejected as invalid input.
MartinRiese
reviewed
Jun 25, 2024
There was a problem hiding this comment.
started backwards because I am not sure how far I got before. Stopped at 15e030b
MartinRiese
reviewed
Jun 25, 2024
| @@ -0,0 +1,7 @@ | |||
| .query-caption.required label::before, .search-query-group-header.required .search-query-group-header-label::before { | |||
| content: '*'; | |||
There was a problem hiding this comment.
🤯 you can set content in css?
There was a problem hiding this comment.
we live in a magical world
| @@ -34,10 +34,3 @@ legend { | |||
| border-top: $cc-neutral-hi solid 1px; | |||
| padding-top: 20px; | |||
| } | |||
|
|
|||
| .question-tile-row { | |||
This doesn't need to be formatted.
* Bootstrap 5 removes the top margin of h1-h6. This affects the collapsible group header layout * Add a class to add an equal margin for h1-h6 top and bottom * Use it for group headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Turn on bootstrap 5 for web apps. Side by side comparisons are here, but the high level summary is: not much changed. Colors are a little brighter, borders are a little lighter, buttons are a little bigger.
Technical Summary
Review by commit. Most commits are small, except the cleanup commits, which are mechanical. Most of this work has been merged already, what remains in this PR is three major changes:
window.USE_BOOTSTRAP5check.Safety Assurance
Safety story
High risk, as this is a high visibility area, there are a lot of changes (including changes made in previous PRs that will go live when this is merged), and our test coverage at the UI level is limited. We'll be going through the same QA/safety approach as for the web apps requirejs migration.
Automated test coverage
Not a whole lot.
QA Plan
https://dimagi.atlassian.net/browse/QA-6550
Rollback instructions
This can be rolled back if needed. Due to its size, it may get difficult to automatically roll back relatively soon, although it looks like there hasn't been that much activity in the web apps front end in the past few weeks.
Sentry can be monitored for javascript errors using this filter.
Labels & Review