some stock optimizations #6838
Merged
some stock optimizations #6838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snopoke
added
the
reindex/migration
| @@ -39,7 +39,7 @@ pytz==2014.10 | |||
| PyYAML==3.10 | |||
| raven==3.1.17 | |||
| requests==2.0.0 | |||
| south==0.7.3 | |||
| south==1.0.2 | |||
There was a problem hiding this comment.
I tested this on staging and was able to deploy without any issues. Also reviewed the change log and didn't see anything that should break (so did @emord: https://github.com/dimagi/commcare-hq/pull/6794/files#r30916913)
Merged
|
👍 from me once tests pass (didn't review super closely though) |
|
Updated to remove the new index (will make a separate PR). This should be gtg. |
snopoke
removed
the
reindex/migration
|
|
||
| ret = {} | ||
| for case_id, section_id, product_id in results: | ||
| sections = ret.setdefault(section_id, {}) |
There was a problem hiding this comment.
just for my own education, any reason to use this over defaultdict?
There was a problem hiding this comment.
No reason in this case.
|
good to merge once tests pass |
|
kicked build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benrudolph
cc @twymer @czue