Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension cases sync #8729

Closed
wants to merge 49 commits into from
Closed

Extension cases sync #8729

wants to merge 49 commits into from

Conversation

proteusvacuum
Copy link
Contributor

Opening for tests / review. This is still in the preliminary stages...
@czue would be great if you could give this a glance (should be easiest commit by commit)

Todo:

  • Fix skipped tests in .json shared test file
  • Test subsequent syncs still do the right thing (e.g. delete, delegate, close, etc. still sends the correct cases)
  • Make sure ownership cleanliness gets set properly with extensions

dimagimon
dimagimon reviewed Oct 19, 2015
View reviewed changes
corehq/ex-submodules/casexml/apps/phone/tests/test_sync_mode.py
@@ -20,6 +20,7 @@
from casexml.apps.phone.restore import CachedResponse, RestoreConfig, RestoreParams, RestoreCacheSettings
from casexml.apps.case.xml import V2, V1
from casexml.apps.case.sharedmodels import CommCareCaseIndex
from casexml.apps.case.const import CASE_INDEX_EXTENSION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F401 'CASE_INDEX_EXTENSION' imported but unused

@czue
Copy link
Member

czue commented Oct 20, 2015

wow, this is a beast! looks great overall and love all the tests. I didn't review those too closely - let me know if you think I should.

@dimagimon
Copy link
Collaborator

There are 9 errors:

  • corehq/ex-submodules/casexml/apps/case/util.py, line 131 - E302 expected 2 blank lines, found 1
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 4 - F401 'CASE_INDEX_EXTENSION' imported but unused
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 5 - F401 'get_reverse_indices_for_case_id' imported but unused
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 9 - F401 'get_extension_cases' imported but unused
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 9 - F401 'get_indexed_cases' imported but unused
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 134 - W291 trailing whitespace
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 146 - E501 line too long (131 > 115 characters)
  • corehq/ex-submodules/casexml/apps/phone/tests/test_cleanliness.py, line 642 - E501 line too long (118 > 115 characters)
  • corehq/ex-submodules/casexml/apps/phone/tests/test_extension_indexes.py, line 105 - E501 line too long (117 > 115 characters)

@proteusvacuum
Copy link
Contributor Author

(just wanted to run tests again, will clean up history and ping when ready for review again)

@proteusvacuum
Update case/related view and add dbaccessor
2a12ece 
The view now emits [domain, referenced_id, "reverse_index",
relationship]
@proteusvacuum
Include extensions in case footprint
b1b67cf
@proteusvacuum
Add extension_index_tree to SimplifiedSyncLog
b02e2fc
@proteusvacuum
Add get_all_dependencies to IndexTree
db68d9e
@proteusvacuum
Add extension indices during sync
f6d69a9
@proteusvacuum
For clean sync, base set includes extensions
8d29b16
@proteusvacuum
Test get_all_dependencies
58bf3a2
@proteusvacuum
Test prune_case
0866dcd
@proteusvacuum
Test SyncTokenUpdates
212d63e
@proteusvacuum
Add shared mobile and HQ tests
fb432c6 
updates sniffer to reload when json files are saved
@proteusvacuum
Don't make case dependent if ther are child indices
81f9e35
@proteusvacuum
Include all index identifiers
01cfc7c
@proteusvacuum
Add extension with 2 hosts
92c29ef
@proteusvacuum
Refactor -> extension updates aren't always live
4a02301 
Makes it clearer that some extension updates aren't live, but are still
added to the case ids on the phone
@proteusvacuum
Refactor -> pull out delete_index
e61b016
@proteusvacuum
Dont sync purged cases that the phone never knew about
49c371a
@proteusvacuum
Fix test
38d6022
@proteusvacuum
get dirtiness flags for all outgoing indices
34d335a
@proteusvacuum
More complex extension chain cleanliness
18d388f
@proteusvacuum
Add branching test
0271d7d
@proteusvacuum
Add changing ownership tests
8eea81f
@proteusvacuum
Verify cleanliness flags
ddb38f2
@proteusvacuum
Get all reverse indices also returns extensions
1a7825f
@dimagimon
Copy link
Collaborator

There are 9 errors:

  • corehq/ex-submodules/casexml/apps/case/util.py, line 131 - E302 expected 2 blank lines, found 1
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 4 - F401 'CASE_INDEX_EXTENSION' imported but unused
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 5 - F401 'get_reverse_indices_for_case_id' imported but unused
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 9 - F401 'get_extension_cases' imported but unused
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 9 - F401 'get_indexed_cases' imported but unused
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 134 - W291 trailing whitespace
  • corehq/ex-submodules/casexml/apps/phone/cleanliness.py, line 146 - E501 line too long (131 > 115 characters)
  • corehq/ex-submodules/casexml/apps/phone/tests/test_cleanliness.py, line 642 - E501 line too long (118 > 115 characters)
  • corehq/ex-submodules/casexml/apps/phone/tests/test_extension_indexes.py, line 105 - E501 line too long (117 > 115 characters)

@proteusvacuum proteusvacuum deleted the extension-cases-sync branch May 16, 2016 18:13
@snopoke snopoke restored the extension-cases-sync branch March 19, 2017 00:05
@proteusvacuum proteusvacuum deleted the extension-cases-sync branch March 21, 2017 19:47
@snopoke snopoke restored the extension-cases-sync branch March 2, 2018 17:40
@proteusvacuum proteusvacuum deleted the extension-cases-sync branch March 26, 2018 19:12
@snopoke snopoke restored the extension-cases-sync branch August 2, 2018 02:28
@proteusvacuum proteusvacuum deleted the extension-cases-sync branch March 29, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Open for review: do not merge A work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@proteusvacuum @czue @dimagimon