CVSU: ucr reports #8975
Merged
CVSU: ucr reports #8975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 6, 2015 13:21
…data are aggregated by alias column.
|
PR doesn't touch existing reports. Ported reports are hidden behind feature flag. |
|
@czue Could you kick build? |
|
done |
|
@kkrampa who usually reviews these reports? |
|
@czue I have no idea because original reports weren't done by Soldevelo devs. |
|
@snopoke is this you? |
|
@czue By new reports I mean old reports ported to UCR so maybe you can just merge and then we can verify on domain that results are the same? |
|
I'll take a look sometime soon (but not today) |
|
Yea, I did the original. I can take a look next week. |
|
I didn't do any actual report QA but the code looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.