update #1
Merged
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* better docs for TransitionGroup about use of `key` prop on children * tweaks from silvenon to merge
* Prevent publishing the docs as a package * Use iframe element directly instead of innerHTML * Bump all dependencies in docs - get out of Gatsby beta - use official Gatsby Babel preset instead of our library's to prevent build failure - upgrade to latest React Bootstrap - bump other inconsequential dependencies
…r webpack tree shaking (#472)
There's an upcoming fix in Node, so we're doing this only temporarily to prevent CI failure. jestjs/jest#8069
## [2.6.1](v2.6.0...v2.6.1) (2019-03-14) ### Bug Fixes * **package.json:** mark react-transition-group as side-effect free for webpack tree shaking ([#472](#472)) ([b81dc89](b81dc89))
- reduce repetitiveness - increase consistency - tweak code blocks and don't omit required props - point from Transition to CSSTransition early on, so people don't miss that information - explain reflow hack better to make it easier to understand the gist of it
This will make it easier to know where to type, so people know to leave a newline before their answer.
Jest mocks are an awesome feature, no need to use sinon.
Now ESLint is configured so it can run across the entire codebase without errors.
# [2.7.0](v2.6.1...v2.7.0) (2019-03-22) ### Features * support ESM (tree-shaking) ([#455](#455)) ([ef3e357](ef3e357))
Since it's a base component that's rarely used on the web, there is no need to add a CodeSandbox demo. Docs for Transition should serve mostly as a reference for CSSTransition and a general intro to react-transition-group.
Add static code blocks to ease the reader into the CodeSandbox demo.
html.js seems to be unnecessary. Other than changing <html> lang attribute, it also seems to be adding a Codepen script which I think was from an older version of the docs which used Codepen instead of CodeSandbox.
It can be null.
## [2.7.1](v2.7.0...v2.7.1) (2019-03-25) ### Bug Fixes * trigger release ([2524b86](2524b86))
Hey! I think it would be quite usefull if `classNames` prop would be optional, and it would still work without it. In our use-case we are using it together with styled components and it's quite annoying to add those prefixes all the time, when component styles are already scoped. Also if you pass empty string, it adds classes beginning with `-`.
# [2.8.0](v2.7.1...v2.8.0) (2019-04-02) ### Features * add support for empty classNames ([#481](#481)) ([d755dc6](d755dc6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.