New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #64

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@SamWhited
Copy link
Contributor

SamWhited commented Dec 17, 2018

Hello,

Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go.

Because this library has no external dependencies, doesn't need to import a package within its own import path, and is already tagging its releases using semver compatible tags, not much changes in the library itself except for declaring the package name and making the major version part of the import path. This means that new projects would now import this library as "github.com/dimfeld/httptreemux/v5". Older versions without a go.mod file would still continue to work but would automatically be converted by the tool to use a special compatibility version.

Thank you for your consideration.

EDIT: it should be noted that I just picked Go 1.9 as the language being used because running tests with 1.9 appeared to work, and that's the earliest version that has some basic support for modules backported into it. Since only things using modules will read this file (and everything else will work exactly as it always had), that seemed like a safe bet for maximum compatibility. If you only support some higher version of Go and want to use features or APIs in a higher version this can be changed easily, of course.

@SamWhited SamWhited force-pushed the SamWhited:module_support branch from 842d4b0 to 795deef Dec 17, 2018

@dimfeld

This comment has been minimized.

Copy link
Owner

dimfeld commented Dec 18, 2018

Thank you!

@dimfeld dimfeld merged commit a454a10 into dimfeld:master Dec 18, 2018

@SamWhited

This comment has been minimized.

Copy link
Contributor Author

SamWhited commented Dec 18, 2018

Thank you for the merge! If you don't have other things to push soon, would you mind also tagging this as v5.0.2? This will give us a tagged version with a go.mod file to pin to.

@SamWhited SamWhited deleted the SamWhited:module_support branch Dec 18, 2018

@dimfeld

This comment has been minimized.

Copy link
Owner

dimfeld commented Dec 18, 2018

Done. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment