Fixed interpolation #384
Merged
Fixed interpolation #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anti-Alias
commented
Jun 18, 2023
src/plugin/systems.rs
Outdated
| @@ -329,21 +329,30 @@ pub fn apply_rigid_body_user_changes( | |||
| }; | |||
|
|
|||
| for (handle, global_transform, mut interpolation) in changed_transforms.iter_mut() { | |||
| let mut transform_changed = None; | |||
There was a problem hiding this comment.
Caching the transform_changed value for potential later use as an Option<bool>.
sebcrozet
force-pushed
the
fix-interpolation
branch
from
583d2cf
to
e0e86b4
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpolation values "start" and "end" are being overwritten every frame rather than only when the user explicitly changes their transform. This causes bevy_rapier to not interpolate properly (if at all).
This PR addresses the following issue:
#341