Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the decimal crate #206

Closed
eugene-bulkin opened this issue Sep 16, 2016 · 2 comments
Closed

Support the decimal crate #206

eugene-bulkin opened this issue Sep 16, 2016 · 2 comments

Comments

@eugene-bulkin
Copy link

eugene-bulkin commented Sep 16, 2016

Is there any way we can support the d128 used in the decimal crate for use in matrices? e.g. I want to have a matrix of d128 values and do stuff with them.

Note: This would require impl-ing BaseNum and Cast<f64> for d128. The last one seems sketchy to me since that cast is not precise.

@sebcrozet
Copy link
Member

We could optionally support this behind a feature. Implementors of the Cast trait are not bound to strong accuracy requirements. They are just expected to return the closest représentable value.
The main difficulty here is that BaseFloat requires num::Float to be implemented and it looks like d128 is still missing all the trigonometric functions.

@milibopp
Copy link
Collaborator

@eugene-bulkin in today's world like all traits that need to be implemented are outside of nalgebra. So if this is still a relevant issue, I would suggest to pursue the integration of decimal with alga and num-traits to make these operations work.

I don't think there is anything to be done here though. Therefore I am going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants