Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nalgebra_glm::cross doesn't use D #637

Closed
talchas opened this issue Aug 20, 2019 · 1 comment
Closed

nalgebra_glm::cross doesn't use D #637

talchas opened this issue Aug 20, 2019 · 1 comment
Labels
breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes enhancement good first issue Good first issue for newcomers. nalgebra-glm Issues about the nalgebra-glm crate. P-high High priority

Comments

@talchas
Copy link

talchas commented Aug 20, 2019 

pub fn cross<N: Number, D: Dimension>(x: &TVec3<N>, y: &TVec3<N>) -> TVec3<N> {
    x.cross(y)
}

It is parameterized on D, but doesn't use it at all, so you have to manually specify a Dimension parameter that isn't used.
@sebcrozet
Copy link
Member

That's an oversight. Would you like to open an PR removing this parameter?

@sebcrozet sebcrozet added breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes enhancement good first issue Good first issue for newcomers. nalgebra-glm Issues about the nalgebra-glm crate. P-high High priority labels Aug 20, 2019
sebcrozet pushed a commit that referenced this issue Oct 28, 2019
@sebcrozet
Fixes #637: removes not used parameter from cross
fedf0fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes enhancement good first issue Good first issue for newcomers. nalgebra-glm Issues about the nalgebra-glm crate. P-high High priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebcrozet @talchas