Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential unsoundness after deserializing a DVector with a bad number or elements. #889

Merged
merged 1 commit into from May 9, 2021

Conversation

sebcrozet
Copy link
Member

Fix #883 and adds tests that would have triggered unsoundness.

@sebcrozet sebcrozet requested a review from Andlon May 6, 2021 16:21
Copy link
Sponsor Collaborator

@Andlon Andlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sebcrozet sebcrozet merged commit a803271 into dev May 9, 2021
@sebcrozet sebcrozet deleted the dvector_deserialize branch May 9, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialize is not sound for VecStorage (and possibly others)
2 participants