Add partial rkyv support
#891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR! A have a few commits ready to make the CI pass, but it looks like you didn't check the PR option that lets me push to your branch directly. Would it be ok for you to check the related box? |
|
Whoops, I was also working on getting this passing. Would the new patch I pushed be okay? |
|
Oh, thanks! Your patch is fine 👍 |
|
Okay I think I did it right! |
|
All good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get nalgebra support started off. It's still missing support for all types as well as tests, but it does have distributive archived types so no logic needs to get rewritten.