Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ContiguousArena::remove #37

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix ContiguousArena::remove #37

merged 1 commit into from
Jun 24, 2024

Conversation

SludgePhD
Copy link
Contributor

Closes #33
Closes #31

Also adds a test

@SludgePhD
Copy link
Contributor Author

Hmm, it's still broken with 3+ entries

@SludgePhD
Copy link
Contributor Author

There we go. The fixup should only happen when an index was removed that is not at the end of the array.

@Vrixyz Vrixyz mentioned this pull request Jun 24, 2024
Closed
@sebcrozet sebcrozet merged commit fe98eaf into dimforge:master Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebcrozet sebcrozet sebcrozet approved these changes

@Vrixyz Vrixyz Vrixyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic when removing boundary
3 participants
@SludgePhD @sebcrozet @Vrixyz