[TypeScript] insomnia-url #2
Conversation
|
although making separate branches is much nicer for GitHub/review purposes, only those packages that have no other dependencies from the project will work since they consume each others' types. For example, insomnia-inso consumes types from insomnia-testing. If I pull those changes out, it will error because it's expecting types. For that reason I've pushed a branch ts/first7 that contains all of these exact same commits, but stacked. If you want to run something, your best bet will be to do so from there. I'll then make sure that everything is always symmetrical between the two. |
| @@ -64,32 +66,34 @@ module.exports.buildQueryParameter = function(param, strict) { | |||
|
|
|||
| // Cast number values to strings | |||
| if (typeof param.value === 'number') { | |||
| param.value += ''; | |||
| param.value = String(param.value); | |||
There was a problem hiding this comment.
oh, don't thank me. TypeScript demands this. both here with the operation, but also in the flexibleEncodeComponent function that follows that only accepts string | undefined (and, not number).
|
after feedback (and all fixex therein) and/or approval this PR is closing because this branch is now being incorporated into the |
No description provided.