Extract http client module from lib #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhamern Could you please rebase your branch. Also If you can please update the README. |
|
Sure I will do it tommorow |
mhamern
force-pushed
the
extract-http-client-module-from-lib
branch
from
2a8bc86
to
292e937
Compare
|
Hi, is there anything holding up the merge? |
|
@mhamern This lib is very nice, but I had the same problem on my Interceptors ... The solution was to migrate to this package has the same behavior, it is likely to be a fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By extracting HttpClientModule from library and let it on user of the library to provide we can avoid bugs introduced by design choice/behaviour of Angular mentioned here: angular/angular#20575
In previous state the library could cause other components imported or declared in same module to use its (more local) HttpClient rather than the one provided in main module of the app. Globally set interceptors would therefore not intercept requests made by those components.
However, it should be clearly mentioned in installation guide because it is breaking change (the component won't load without importing HttpClientModule in client app)
#159