Skip to content
This repository has been archived by the owner. It is now read-only.

Added orWhereTranslation and orWhereTranslationLike scopes #338

Merged
merged 3 commits into from Jun 7, 2017

Conversation

@voidgraphics
Copy link
Contributor

commented Apr 13, 2017

We noticed some scopes were missing, so we added them.
Hope this helps!

@Gummibeer

This comment has been minimized.

Copy link
Collaborator

commented Apr 15, 2017

I think there are a lot of Scopes that can be added, the question is: does it make sense to add all available scopes to a package that adds the base logic and has no problems to get extended.
Everyone can extend the Translatable trait by scopes and whatever he misses - for my own packages, we just add the real base of scopes, wrappers etc.

@dimsav

This comment has been minimized.

Copy link
Owner

commented Jun 7, 2017

@voidgraphics thank you!

@dimsav dimsav merged commit c812a51 into dimsav:master Jun 7, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.