Skip to content
This repository has been archived by the owner on Jun 18, 2019. It is now read-only.

Added orWhereTranslation and orWhereTranslationLike scopes #338

Merged
merged 3 commits into from
Jun 7, 2017
Merged

Added orWhereTranslation and orWhereTranslationLike scopes #338

merged 3 commits into from
Jun 7, 2017

Conversation

voidgraphics
Copy link
Contributor

We noticed some scopes were missing, so we added them.
Hope this helps!

@Gummibeer
Copy link
Collaborator

I think there are a lot of Scopes that can be added, the question is: does it make sense to add all available scopes to a package that adds the base logic and has no problems to get extended.
Everyone can extend the Translatable trait by scopes and whatever he misses - for my own packages, we just add the real base of scopes, wrappers etc.

@dimsav
Copy link
Owner

dimsav commented Jun 7, 2017

@voidgraphics thank you!

@dimsav dimsav merged commit c812a51 into dimsav:master Jun 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants