Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4136 by Inlead: Use core function and not variable-contrib function. #1392

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

inlead
Copy link
Contributor

@inlead inlead commented Mar 21, 2019

Link to issue

https://platform.dandigbib.org/issues/4136

Description

This change-set prevents DBCs environment to fail upon deployment of ddb_cp-active clients.
Apparently variable_delete() is a function from within the variable-contrib modul and not Drupal core. Since the variable module is only used by the ddb_cp module, it was only reproducible on "Webmaster"-libraries.

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

Additional comments or questions

This only solves the problem and does not prevent any future errors of similar kind in regards to deployment.

@kasperg kasperg merged commit 3b9da95 into ding2:master Mar 21, 2019
@guddo guddo deleted the bug/issue-4136 branch March 27, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants