4625 by Inlead: Adopt with recent service changes. #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
approved these changes
Nov 15, 2019
|
Please look into the scrutinizer comment about watchdog: The second argument to watchdog() should not be enclosed with t() |
cableman
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://platform.dandigbib.org/issues/4625
Description
This PR restores the original flow for pulling images during syndication of new content from BPI service. There is a long history for this logic to be broken and this is restored via this change-set. Images from title/list image fields are placed correspondingly during syndication along with inline images inserted into body via WYSIWYG.
Checklist
Additional comments or questions
Relying on ding2/bpi-client#16.