Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5059: off-site payments #1753

Merged
merged 8 commits into from
Apr 8, 2021
Merged

5059: off-site payments #1753

merged 8 commits into from
Apr 8, 2021

Conversation

xendk
Copy link
Contributor

@xendk xendk commented Feb 11, 2021

Link to issue

https://platform.dandigbib.org/issues/5059

Description

Refactors debs to be split in on-site and off-site payments, with a separate section for each type. Much moving about and cleaning up.

Screenshot of the result

User page:
ddb-5059-3

Admin:
ddb-5059-admin-2

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

@xendk
Copy link
Contributor Author

xendk commented Feb 11, 2021

The scrutizier errors are existing issues, I rated consistency higher than fixing old errors.

The behat tests? Hell if I know.

@kasperg kasperg merged commit bce223b into ding2:master Apr 8, 2021
@kasperg kasperg deleted the 5059-payment-options branch April 8, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants