Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5037: Introduce section teaser #1756

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Conversation

xendk
Copy link
Contributor

@xendk xendk commented Feb 18, 2021

Link to issue

https://platform.dandigbib.org/issues/5037

Description

Add a teaser field to sections for rendering in section groups.

Screenshot of the result

image

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

@holt83
Copy link
Member

holt83 commented Feb 18, 2021

Nice looks useful :)

Was wondering: any reason the section (and fields) is not exported with features?

@xendk
Copy link
Contributor Author

xendk commented Feb 19, 2021

Ask the original developer. 🤷

I've mentioned that it would be smart to get that fixed on https://platform.dandigbib.org/issues/4276

Copy link
Member

@cableman cableman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seams that the new field only is installed in an update hook and not on new sites?

Should the field also have been added to _ding_sections_create_fields?

@kasperg kasperg merged commit f614a53 into ding2:master Apr 8, 2021
@kasperg kasperg deleted the 5037-section-teasers branch April 8, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants