Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accounts panel width (#797) #1017

Merged
merged 3 commits into from Mar 24, 2021
Merged

Conversation

sshikaree
Copy link
Contributor

No description provided.

Copy link
Member

@fiaxh fiaxh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I think it would be suitable to put those changes directly into the LabelHybrid (the parent of EntryLabelHybrid). That way, we fix the "widget gets to large and messes up window dimensions" issue for all usages of the LabelHybrid.

@sshikaree
Copy link
Contributor Author

sshikaree commented Mar 24, 2021

Maybe it would be more consistent to add those changes here in properties list?

@fiaxh
Copy link
Member

fiaxh commented Mar 24, 2021

@sshikaree Sounds good 👍

@fiaxh fiaxh merged commit 45c0ac4 into dino:master Mar 24, 2021
LAGonauta pushed a commit to LAGonauta/dino that referenced this pull request Mar 26, 2021
LAGonauta pushed a commit to LAGonauta/dino that referenced this pull request Mar 27, 2021
fiaxh pushed a commit that referenced this pull request Jun 3, 2021
fiaxh pushed a commit that referenced this pull request Jun 7, 2021
@sshikaree sshikaree deleted the fix_accounts_panel branch July 22, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants