Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment a return that stop every notifications to be trigger when an account is not synced #432

Merged
merged 2 commits into from
Oct 24, 2018
Merged

Comment a return that stop every notifications to be trigger when an account is not synced #432

merged 2 commits into from
Oct 24, 2018

Conversation

PapsOu
Copy link
Contributor

@PapsOu PapsOu commented Sep 27, 2018

No description provided.

@PapsOu PapsOu mentioned this pull request Sep 27, 2018
Closed
@PapsOu
Copy link
Contributor Author

PapsOu commented Oct 3, 2018

I've changed the fix to a better one (that should not break notifications with MAM available).

I don't have the possibility to test if it works with a MAM compatible account, so please let me know if this break something ?

@licaon-kter
Copy link
Contributor

licaon-kter commented Oct 3, 2018 •
edited
Loading

Do create a free account somewhere and test.

@PapsOu
Copy link
Contributor Author

PapsOu commented Oct 3, 2018

OK I've tested with two accounts freshly created on https://jabberfr.org/ and notifications seems to work too when MAM is supported.

You can merge this PR if it seems OK for you

@fiaxh fiaxh merged commit 4ad07fe into dino:master Oct 24, 2018
@fiaxh
Copy link
Member

fiaxh commented Oct 24, 2018

Thanks!

Rahix added a commit to Rahix/dino that referenced this pull request May 16, 2019
@Rahix
Fix notifications for severs without MAM
d6fecfe 
This commit re-adds the change from 4ad07fe:

    Fix messages never being notified from servers without MAM (dino#432)

Signed-off-by: Rahix <rahix@rahix.de>
Rahix added a commit to Rahix/dino that referenced this pull request May 16, 2019
@Rahix
Fix notifications for servers without MAM
80b946c 
This commit re-adds the change from 4ad07fe:

    Fix messages never being notified from servers without MAM (dino#432)

Signed-off-by: Rahix <rahix@rahix.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PapsOu @licaon-kter @fiaxh