Authorization actuary #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase needed! |
diogomonica
reviewed
Aug 18, 2017
cmd/actuary/server/services/acl.go
Outdated
| @@ -0,0 +1,49 @@ | |||
| package services | |||
There was a problem hiding this comment.
This seems a bit too complex. We don't actually need user-management.
diogomonica
reviewed
Aug 18, 2017
cmd/actuary/server/server.go
Outdated
| @@ -68,7 +113,16 @@ var ( | |||
| TLSNextProto: make(map[string]func(*http.Server, *tls.Conn, http.Handler), 0), | |||
| } | |||
|
|
|||
| api := NewAPI(os.Getenv("TLS_CERT"), os.Getenv("TLS_KEY")) | |||
|
|
|||
| // mux.Handle("/users", AddMiddleware(api.Users, | |||
diogomonica
reviewed
Aug 18, 2017
cmd/actuary/server/server.go
Outdated
| } | ||
|
|
||
| func (report *outputData) postResults(w http.ResponseWriter, r *http.Request, reqList *[]check.Request) { | ||
| w.Header().Add("Strict-Transport-Security", "max-age=63072000; includeSubDomains") |
There was a problem hiding this comment.
Probably not a good idea for a website that won't have a valid TLS cert?
diogomonica
reviewed
Aug 18, 2017
| @@ -0,0 +1,106 @@ | |||
| package server | |||
There was a problem hiding this comment.
I don't see any tests of this functionality.
|
Rebase needed! |
added 2 commits
August 22, 2017 13:51
Signed-off-by: Olivia Barnett <oliviabarnett2019@u.northwestern.edu>
oliviabarnett
force-pushed
the
authorization-actuary
branch
2 times, most recently
from
c904748
to
c2ace6f
Compare
Signed-off-by: Olivia Barnett <oliviabarnett2019@u.northwestern.edu>
oliviabarnett
force-pushed
the
authorization-actuary
branch
from
c2ace6f
to
1c7e179
Compare
diogomonica
reviewed
Aug 29, 2017
cmd/actuary/server/api.go
Outdated
| Tokens *handlers.Tokens | ||
| } | ||
|
|
||
| func randomize() []byte { |
diogomonica
reviewed
Aug 29, 2017
cmd/actuary/server/api.go
Outdated
| b := make([]byte, c) | ||
| _, err := rand.Read(b) | ||
| if err != nil { | ||
| log.Fatalf("Could not randomize signing key: %v", err) |
There was a problem hiding this comment.
Failed when generating random bytes
diogomonica
reviewed
Aug 29, 2017
cmd/actuary/server/handlers/token.go
Outdated
| var username string | ||
| var ok bool | ||
|
|
||
| w.Header().Add("Strict-Transport-Security", "max-age=63072000; includeSubDomains") |
diogomonica
reviewed
Aug 29, 2017
| @@ -12,6 +12,7 @@ | |||
| </head> | |||
|
|
|||
| <body> | |||
|
|
|||
diogomonica
reviewed
Aug 29, 2017
| @@ -73,3 +73,15 @@ ul { | |||
| list-style-type: disc; | |||
| font-size: large; | |||
| } | |||
|
|
|||
| .input-box{ | |||
| height: 3em; | |||
diogomonica
reviewed
Aug 29, 2017
cmd/actuary/server/server.go
Outdated
| nodeID := string(req.NodeID) | ||
| results := req.Results | ||
| report.Mu.Lock() | ||
| report.Outputs[nodeID] = results |
There was a problem hiding this comment.
We could also use the new sync.Map
Signed-off-by: Olivia Barnett <oliviabarnett2019@u.northwestern.edu>
diogomonica
reviewed
Aug 31, 2017
cmd/actuary/server/server.go
Outdated
| w.Write(report.Outputs[nodeID]) | ||
| report.Mu.Unlock() | ||
| i, ok := report.Load(nodeID) | ||
| val := i.([]byte) |
There was a problem hiding this comment.
Move this after the !ok check
diogomonica
reviewed
Aug 31, 2017
cmd/actuary/server/server.go
Outdated
| var report = outputData{Mu: &sync.Mutex{}, Outputs: m} | ||
| //m := make(map[string][]byte) | ||
| report := syncmap.Map{} | ||
| //var report = outputData{Mu: &sync.Mutex{}, Outputs: m} |
Signed-off-by: Olivia Barnett <oliviabarnett2019@u.northwestern.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JWTs. Authentication between nodes/server and js/server set up