-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF: Replaces our own custom progressbar with a tqdm progressbar. #2227
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2227 +/- ##
==========================================
- Coverage 91.36% 91.35% -0.01%
==========================================
Files 252 252
Lines 32941 32932 -9
Branches 3465 3466 +1
==========================================
- Hits 30095 30086 -9
- Misses 2085 2086 +1
+ Partials 761 760 -1
|
I'm at a bit of a loss here. Why is Travis not picking up the tqdm dependency from here on the Travis |
I do not know the impact of this line but it might be because of that. I realize that we forgot it for |
Hi @arokem, This PR is close to being done, Can you try the proposition above? |
Also, specifies a minimal version.
Thanks for the tip @skoudoro! Let's see if this does the trick. |
Looks like the failures are now all unrelated to this PR. |
Indeed, Looks good to me so merging! thanks @arokem |
Closes #2219.