PEP8 in sims #884 #983
Closed
PEP8 in sims #884 #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +68,7 @@ def test_add_noise(): | |||
| N = 50 | |||
| S0 = 100 | |||
|
|
|||
| options = dict(func=f, | |||
| options=dict(func=f, | |||
There was a problem hiding this comment.
This was actually fine before, I believe.
|
Thanks. A few small comments. |
|
Fixed both. |
| @@ -78,7 +80,7 @@ def test_add_noise(): | |||
| vol = orbital_phantom(gtab, **options) | |||
|
|
|||
| for snr in [10, 20, 30, 50]: | |||
| vol_noise = orbital_phantom(gtab, snr=snr, **options) | |||
| vol_noise = orbital_phantom(gtab, snr = snr, **options) | |||
There was a problem hiding this comment.
Sorry - missed this one before. This = shouldn't have whitespace around it.
|
Real close here. One more teensy comment. |
|
Fixing it in 5! |
|
Did you get a chance to fix this one? |
Fixes dipy#884
|
This one needs a rebase. |
|
Hey @theaverageguy : mind giving this one a rebase? It's got some conflicts with other things that got merged into master since. |
|
I assume this has been abandoned, but feel free to reopen if you still want to work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884