Added edge case handling for weird IBM ldap issues (#9527)

* Added edge case handling for weird IBM ldap issues * Update api/src/exceptions/unexpected-response.ts
directus · Dec 10, 2021 · 63ade9b · 63ade9b
1 parent c777520
commit 63ade9b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/api/src/auth/drivers/ldap.ts b/api/src/auth/drivers/ldap.ts
@@ -5,6 +5,7 @@ import ldap, {
 	EqualityFilter,
 	SearchCallbackResponse,
 	SearchEntry,
+	LDAPResult,
 	InappropriateAuthenticationError,
 	InvalidCredentialsError,
 	InsufficientAccessRightsError,
@@ -19,6 +20,7 @@ import {
 	InvalidPayloadException,
 	ServiceUnavailableException,
 	InvalidConfigException,
+	UnexpectedResponseException,
 } from '../../exceptions';
 import { AuthenticationService, UsersService } from '../../services';
 import asyncHandler from '../../utils/async-handler';
@@ -98,6 +100,13 @@ export class LDAPAuthDriver extends AuthDriver {
 						}
 					});
 				});
+
+				res.on('end', (result: LDAPResult | null) => {
+					if (result?.status === 0) {
+						// Handle edge case with IBM systems where authenticated bind user could not fetch their DN
+						reject(new UnexpectedResponseException('Failed to find bind user record'));
+					}
+				});
 			});
 		});
 	}

diff --git a/api/src/exceptions/index.ts b/api/src/exceptions/index.ts
@@ -15,3 +15,4 @@ export * from './route-not-found';
 export * from './service-unavailable';
 export * from './unprocessable-entity';
 export * from './user-suspended';
+export * from './unexpected-response';
diff --git a/api/src/exceptions/unexpected-response.ts b/api/src/exceptions/unexpected-response.ts
@@ -0,0 +1,7 @@
+import { BaseException } from '@directus/shared/exceptions';
+
+export class UnexpectedResponseException extends BaseException {
+	constructor(message: string) {
+		super(message, 503, 'UNEXPECTED_RESPONSE');
+	}
+}