Skip to content

Commit

Permalink
Fix empty current permissions (#10236)
Browse files Browse the repository at this point in the history
  • Loading branch information
joselcvarela committed Dec 2, 2021
1 parent b1af0a1 commit 7966b4e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions api/src/utils/merge-permissions.ts
@@ -1,4 +1,4 @@
import { flatten, merge, omit } from 'lodash';
import { flatten, merge, omit, isEmpty } from 'lodash';
import { Permission, LogicalFilterOR } from '@directus/shared/types';

export function mergePermissions(...permissions: Permission[][]): Permission[] {
Expand Down Expand Up @@ -26,12 +26,12 @@ function mergePerm(currentPerm: Permission, newPerm: Permission) {
let fields = currentPerm.fields;
let presets = currentPerm.presets;

if (newPerm.permissions) {
if (newPerm.permissions && !isEmpty(newPerm.permissions)) {
if (currentPerm.permissions && Object.keys(currentPerm.permissions)[0] === '_or') {
permissions = {
_or: [...(currentPerm.permissions as LogicalFilterOR)._or, newPerm.permissions],
};
} else if (currentPerm.permissions) {
} else if (currentPerm.permissions && !isEmpty(currentPerm.permissions)) {
permissions = {
_or: [currentPerm.permissions, newPerm.permissions],
};
Expand Down

0 comments on commit 7966b4e

Please sign in to comment.