Skip to content

Commit

Permalink
Speed improvment (#1417)
Browse files Browse the repository at this point in the history
* Removed static Text from settings page, replaced with language identifiers

* removed "east germany", since 1989 germany is one country ;)

* removed static text from filter widget

* Fixed Uncaught TypeError MultipleFiles

because Element has no data Attributes, changed to get parent data attributes

* Fixed Uncaught TypeError MultipleFiles

changed edit-item event

* Backend Speed- Improvement

Disables default Relationdata Loading, gets them only if they are really needed. (columns/columns_visible not set)
  • Loading branch information
WorksDev authored and wellingguzman committed Apr 26, 2017
1 parent 2095846 commit dcaa963
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -773,8 +773,8 @@ public function loadItems(array $params = [], \Closure $queryCallback = null)
$builder = new Builder($this->getAdapter());
$builder->from($this->getTable());

if (ArrayUtils::has($params, 'columns')) {
$columns = array_unique(array_merge($tableSchema->getPrimaryKeysName(), $params['columns']));
if (ArrayUtils::has($params, 'columns') || ArrayUtils::has($params, 'columns_visible')) {
$columns = array_unique(array_merge($tableSchema->getPrimaryKeysName(), ArrayUtils::get($params, 'columns', []), ArrayUtils::get($params, 'columns_visible', [])));
} else {
$columns = $tableSchema->getColumnsName();
}
Expand Down Expand Up @@ -806,7 +806,7 @@ public function loadItems(array $params = [], \Closure $queryCallback = null)

$depth = ArrayUtils::get($params, 'depth', null);
if ($depth !== null) {
$paramColumns = ArrayUtils::get($params, 'columns', []);
$paramColumns = array_merge(ArrayUtils::get($params, 'columns', []), ArrayUtils::get($params, 'columns_visible', []));
$relationalColumns = $tableSchema->getRelationalColumnsName();

if ($paramColumns) {
Expand Down

0 comments on commit dcaa963

Please sign in to comment.