Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical performance regression in Postgres since merge of CockroachDB #11209

Closed
rijkvanzanten opened this issue Jan 21, 2022 · 1 comment · Fixed by knex/knex-schema-inspector#93 or #11238
Closed

Critical performance regression in Postgres since merge of CockroachDB #11209

rijkvanzanten opened this issue Jan 21, 2022 · 1 comment · Fixed by knex/knex-schema-inspector#93 or #11238
Assignees
@rijkvanzanten @nickrum
Labels
🍰 Bug 🕋 Postgres
Milestone
v9.5.0

Comments

@rijkvanzanten
Copy link
Member

To support Cockroach, we had to add an additional where statement to the columnInfo inspection:

knex/knex-schema-inspector@118634c

This turns out to tremendously hurt performance on Postgres. A solution is in the works (see linked PR).
@rijkvanzanten rijkvanzanten added this to the v9.5.0 milestone Jan 21, 2022
rijkvanzanten added a commit to knex/knex-schema-inspector that referenced this issue Jan 21, 2022
@rijkvanzanten
Rework PG to use (way faster) pg_catalog
b6a9e1d 
Fixes directus/directus#11209
@rijkvanzanten rijkvanzanten mentioned this issue Jan 21, 2022
Merged
@rijkvanzanten
Copy link
Member Author

Also ensure the nested transactions in DDL operations are resolved

@azrikahar azrikahar mentioned this issue Jan 24, 2022
Closed
3 tasks
rijkvanzanten added a commit to knex/knex-schema-inspector that referenced this issue Jan 24, 2022
@rijkvanzanten @nickrum
Rework PG to use (way faster) pg_catalog (#93)
efc047e 
* Rework PG to use (way faster) pg_catalog

Fixes directus/directus#11209

* Add schema search, update columns

* Update .tableInfo

* Update .tables()

* Update hasTable

* Update primary

* Update foreignKeys call

* Start on dedicated CockroachDB implementation

* Use information schema based introspection in CockroachDB

* Update lib/dialects/postgres.ts

Co-authored-by: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>

Co-authored-by: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
@rijkvanzanten rijkvanzanten mentioned this issue Jan 24, 2022
Merged
@azrikahar azrikahar mentioned this issue Jan 25, 2022
Closed
3 tasks
joselcvarela pushed a commit to joselcvarela/knex-schema-inspector that referenced this issue May 24, 2023
@rijkvanzanten @nickrum @joselcvarela
Rework PG to use (way faster) pg_catalog (knex#93)
ca1ec40 
* Rework PG to use (way faster) pg_catalog

Fixes directus/directus#11209

* Add schema search, update columns

* Update .tableInfo

* Update .tables()

* Update hasTable

* Update primary

* Update foreignKeys call

* Start on dedicated CockroachDB implementation

* Use information schema based introspection in CockroachDB

* Update lib/dialects/postgres.ts

Co-authored-by: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>

Co-authored-by: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rijkvanzanten rijkvanzanten

@nickrum nickrum

Labels
🍰 Bug 🕋 Postgres
Projects
None yet
Milestone
v9.5.0
2 participants
@rijkvanzanten @nickrum