Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hebrew issues on API #1963

Closed
neran opened this issue Nov 22, 2017 · 5 comments
Closed

Hebrew issues on API #1963

neran opened this issue Nov 22, 2017 · 5 comments
Assignees

Comments

@neran
Copy link

neran commented Nov 22, 2017

Hebrew values are messed up on API calls due to json_encode function.
Fix:
/api/core/Directus/Application/Application.php, line 140
Change
$response->setBody(json_encode($data));
To
$response->setBody(json_encode($data,JSON_UNESCAPED_UNICODE));

@wellingguzman
Copy link

Hey @neran can you please show us some example that we can use to reproduce this?

@wellingguzman
Copy link

Or better yet, if you have a way to fix it, we would love that fix in a PR.

@neran
Copy link
Author

neran commented Nov 22, 2017

Sure, when I write Hebrew in a table and try to get the items by API, this is what I get:
screenshot at nov 22 19-30-25

After applying the fix, here's how it looks:
screenshot at nov 22 19-31-26

Awesome software btw, really enjoy it.
Will try a PR.

@wellingguzman
Copy link

Thanks @neran!

@wellingguzman wellingguzman self-assigned this Nov 24, 2017
@wellingguzman wellingguzman added this to the 6.4 (Ruby Rabbit) milestone Nov 24, 2017
@wellingguzman
Copy link

Hey @neran, I have took you fix and push it myself.

Thanks for the report and the fix.

Closed by 3efe10d

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants