Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: Use AUTH_<PROVIDER>_MODE for auth requests #21914

Closed
joselcvarela opened this issue Mar 20, 2024 · 1 comment
Closed

App: Use AUTH_<PROVIDER>_MODE for auth requests #21914

joselcvarela opened this issue Mar 20, 2024 · 1 comment

Comments

@joselcvarela
Copy link
Member

Describe the Bug

In #21239 it was introduced a session mode which uses a cookie to keep user logged in.
Although this have broke some behaviour we had previously.
For example, when project is using Seamless SSO it may be using cookie for AUTH_<PROVIDER>_MODE.
But the user will not be able to use the App as it is strictly set to session mode.

In order to fix this, App should use the mode that is set on AUTH_<PROVIDER>_MODE

To Reproduce

Setup some SSO mechanism and then set AUTH_<PROVIDER>_MODE to cookie.
Now it will not be possible to login into the App, using the SSO provider

Directus Version

main (10.10.4)

Hosting Strategy

Self-Hosted (Custom)

@paescuj
Copy link
Member

paescuj commented Mar 20, 2024

Duplicate of #21836, will be fixed with #21874 👍

@paescuj paescuj closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants