Hiding non session SSO providers from the app #21874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7cc5ffd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Would it be problematic from a security point of view, to expose the sessionOnly flag for the endpoint, and set it to true when fetching in Data Studio? Or maybe even expose the mode for each provider and filter by that on Data Studio side?
That way it wouldn't be a breaking change for the /auth endpoint, resp. still possible to see all providers.
|
Good shout, i dont see a security issue with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21836
Scope
What's changed:
/authlist endpoint now filters out SSO providers not compatible with the App while keeping the/auth/login/[provider]flow workingPotential Risks / Drawbacks
/authendpointReview Notes / Questions