Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated words are not translated #7033

Closed
dimitrov-adrian opened this issue Jul 28, 2021 · 2 comments · Fixed by #7045
Closed

Translated words are not translated #7033

dimitrov-adrian opened this issue Jul 28, 2021 · 2 comments · Fixed by #7045
Assignees
Labels
Milestone

Comments

@dimitrov-adrian
Copy link
Contributor

dimitrov-adrian commented Jul 28, 2021

Describe the Bug

Translated phrases in the yaml files are not recognized and displayed.

To Reproduce

Just check for "delete" somewhere in the interface, for example in Bulgarian or most of the languages have it translated.

It seems that the issue is come from yaml importing in

const translations = await import(`./translations/${lang}.yaml`);

As translations.delete is always empty, it seems that such reserved words cannot be used here with yaml import

Ref: https://github.com/rollup/plugins/blob/8748b8cd3bbab3c5ac6190556930219f19060e63/packages/pluginutils/src/makeLegalIdentifier.ts#L4

What version of Directus are you using?

rc86

What version of Node.js are you using?

16

What database are you using?

sqlite

What browser are you using?

chrome

What operating system are you using?

macos/linux

How are you deploying Directus?

locally

@rijkvanzanten
Copy link
Member

What a wonderfully edge-case specific bug. Thanks for the heads up!

@rijkvanzanten
Copy link
Member

@nickrum another wonderful rollup quirk

@rijkvanzanten rijkvanzanten self-assigned this Jul 28, 2021
@rijkvanzanten rijkvanzanten added this to the v9.0.0-rc.87 milestone Jul 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants